fix: ensure ParentProps is declared as a type import #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d66b4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paularmstrong
force-pushed
the
fix-error-boundary-issue
branch
from
60ffb92 to
4d66b4d
Compare
|
It looks like there are some other locations this happens as well. What's the intended process here? I can work around this by having vite include solid-start: import { defineConfig } from '@solidjs/start/config';
export default defineConfig({
optimizeDeps: {
include: ['@solidjs/start/**/*.tsx'],
},
}); |
|
Making it a type import where it should be is always best. Thanks. |
|
@ryansolid are you open to adding eslint to the project? the @typescript-eslint/consistent-type-imports rule can auto-fix this and prevent regressions. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1311
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In the console, the following error appears:
The error prevents client-side interaction other than navigation.
Building the application and running production mode does not have the error.
What is the new behavior?
No more syntax error in browser.
I verified this works by manually modifying the code from NPM when creating my application.
Note
This was not reproducible within the solid-start repository. I suspect it has to do with local tsc compiling/configs?
Other information